-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix[MQB]: respect protocol file size limits #539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 400 of commit 7fe8a8d has completed with FAILURE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 402 of commit f6a176c has completed with FAILURE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
Signed-off-by: Evgeny Malygin <[email protected]>
Signed-off-by: Evgeny Malygin <[email protected]>
Signed-off-by: Evgeny Malygin <[email protected]>
Signed-off-by: Evgeny Malygin <[email protected]>
f6a176c
to
a169001
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 410 of commit a169001 has completed with FAILURE
Before this PR, it was possible to set a file size not complaint to the protocol limitations. In this case, the cluster will work until it gets the first offset overflow, and then crash.
This PR:
mqbblp::StorageManager::start
(for non-FSM) andmqbc::StorageManager::start
(for FSM) to gracefully return a failure RC on file size overflow.FileStoreSet::setDataFileSize
etc), they should be never triggered in a normal workflow but left here just to be sure.mqbblp
/mqbc
]::StorageManager::start
mqbc::StorageManager
(there are no UTs formqbblp::StorageManager
).The error logs look like this: