Fix[bmqstoragetool, bmq, mqb]: Fix several warnings #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallfox
changed the title
678098
approved these changes
Dec 7, 2024
678098
requested changes
Dec 7, 2024
chrisbeard
reviewed
Dec 9, 2024
| @@ -262,25 +262,6 @@ struct PortMatcher { | |||
| return listener.port() == d_port; | |||
| } | |||
| }; | |||
|
|
|||
| template <typename T> | |||
| T* channelCast(bmqio::Channel* base) | |||
There was a problem hiding this comment.
This was just dead code we never removed? Happy to see it removed :)
There was a problem hiding this comment.
This might be related to TLS change, where we were needed to find a concrete bmqio::Channel implementation within the chain of nested bmqio::Channels
chrisbeard
reviewed
Dec 9, 2024
m_bmqstoragetool ================ FileManager - Follow ISO C++ destructor rules FileManagerMock - Fix weak-vtable SearchShortResult - Remove unused d_allocator_p parameter - Add allocator() method to retrieve allocator from subobject bmq === bmqa_mocksession - Remove unused const overload of uriCorrIdToQueues bmqma_countingallocator - Properly mark CountingAllocator::configureStatContextTableInfoProvider as deprecated bmqtst_logcontroller - Add missing cases in switch statement mqb === mqba_commandrouter - Mark CommandRouter::ClusterWideRoutingMode::getRouteTargets errorDescription as unused - Move RoutingMode::~RoutingMode() to implementation file mqba_sessionnegotiator - Escape '@' character used by doxygen special command parsing mqbcfg_tcpinterfaceconfigvalidator - Add newline to end of header mqbi_queueengine - Mark QueueEngine::logAppSubscription appId as unused mqbmock_storagemanager - Force assertion failure for unimplemented StorageManager::fileStore mqbnet_tcpsessionfactory - Remove unused channelCast() helper Signed-off-by: Taylor Foxhall <[email protected]>
678098
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_bmqstoragetool
FileManager
FileManagerMock
SearchShortResult
bmq
bmqa_mocksession
bmqma_countingallocator
bmqtst_logcontroller
mqb
mqba_commandrouter
mqba_sessionnegotiator
mqbcfg_tcpinterfaceconfigvalidator
mqbi_queueengine
mqbmock_storagemanager
mqbnet_tcpsessionfactory