Perf[MQB]: inline stats onEvent #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Petukhov <[email protected]>
Signed-off-by: Dmitry Petukhov <[email protected]>
Signed-off-by: Dmitry Petukhov <[email protected]>
Signed-off-by: Dmitry Petukhov <[email protected]>
Signed-off-by: Dmitry Petukhov <[email protected]>
tepamid
force-pushed
the
perf-inline-stats-onevent
branch
from
0796ed0 to
982aac0
Compare
678098
reviewed
Dec 11, 2024
| inline void | ||
| BrokerStats::onEvent<BrokerStats::EventType::Enum::e_CLIENT_CREATED>() | ||
| { | ||
| BSLS_ASSERT_SAFE(d_statContext_p && "initialize was not called"); |
There was a problem hiding this comment.
Not in the scope of this PR, but It's a pity that we check this condition on every metric update. Would be nice to ensure initialization on construction, so Stats classes are impossible to construct without this.
|
|
||
| /// Namespace for the constants of stat values that applies to the queues | ||
| /// on the domain | ||
| struct DomainQueueStats { |
There was a problem hiding this comment.
Also might be a private type for QueueStatsDomain
There was a problem hiding this comment.
Can not make it private, because it's used in QueueStatsUtil::initializeTableAndTipDomains
My suggestion is to put struct DomainQueueStats into public section in class QueueStatsDomain
| } break; | ||
| }; | ||
| } | ||
|
|
||
| void QueueStatsDomain::onEvent(EventType::Enum type, | ||
| bsls::Types::Int64 value, | ||
| const bsl::string& appId) |
There was a problem hiding this comment.
This onEvent (per-appId one) is not templated/inlined in this PR. It's okay, we can do it later.
Signed-off-by: Dmitry Petukhov <[email protected]>
Signed-off-by: Dmitry Petukhov <[email protected]>
Signed-off-by: Dmitry Petukhov <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Dmitry Petukhov <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Dmitry Petukhov <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Dmitry Petukhov <[email protected]>
Signed-off-by: Dmitry Petukhov <[email protected]>
Signed-off-by: Dmitry Petukhov <[email protected]>
Signed-off-by: Dmitry Petukhov <[email protected]>
tepamid
force-pushed
the
perf-inline-stats-onevent
branch
from
9128dec to
c233c42
Compare
Signed-off-by: Dmitry Petukhov <[email protected]>
|
Merged with upstream main. All workflows passed |
678098
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refactor QueueStatsDomain, DomainStats, ClusterNodeStats and BrokerStats to make function onEvent inline which supposedly should increase overall performance of the system.
Testing performed
Additional context