fix: proxy detects non-consecutive duplicates #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorjesinpo
requested review from
pniedzielski
and removed request for
a team
dorjesinpo
force-pushed
the
fix/duplicate-detection-in-proxy
branch
from
d4b73aa to
c658247
Compare
dorjesinpo
changed the title
Signed-off-by: dorjesinpo <[email protected]>
dorjesinpo
force-pushed
the
fix/duplicate-detection-in-proxy
branch
from
c658247 to
a6dcd0d
Compare
dorjesinpo
changed the title
pniedzielski
requested changes
Dec 18, 2024
|
|
||
| App(const bsl::shared_ptr<RelayQueueEngine_AppState>& app); | ||
| void add(Element* element); | ||
| void remove(Element* element); | ||
|
|
||
| /// Return 'true' |
There was a problem hiding this comment.
This documentation comment doesn't seem correct/seems unfinished.
| // The current element has made it either to delivery or | ||
| // putAside and it can be removed | ||
| d_storageIter_mp->removeCurrentElement(); | ||
| else if (element->app().setLastPush(d_storageIter_mp->guid())) { |
There was a problem hiding this comment.
Can we break this function into isLastPush(guid) (pure function, does not set state) and setLastPush(guid) (unconditionally overwrites state)? This condition is very hard to understand, reading it as English, and the return value is already ignored in the else branch below.
There was a problem hiding this comment.
ok. we also need removeCurrentElement
| @@ -270,7 +270,6 @@ VirtualStorageCatalog::confirm(const bmqt::MessageGUID& msgGUID, | |||
| VirtualStoragesIter it = d_virtualStorages.findByKey2(appKey); | |||
| BSLS_ASSERT_SAFE(it != d_virtualStorages.end()); | |||
|
|
|||
| setup(&data->second); | |||
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
VirtualStorageCatalog::get calls setup so the second call was redundant
Signed-off-by: dorjesinpo <[email protected]>
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
pniedzielski
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the case of non-consecutive PUSH duplicates