Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDISCROWD-7704: Update task with checksum value #1020

Merged
merged 2 commits into from
Dec 20, 2024
Merged

RDISCROWD-7704: Update task with checksum value #1020

merged 2 commits into from
Dec 20, 2024

Conversation

dchhabda
Copy link

@dchhabda dchhabda commented Dec 19, 2024 •
edited
Loading

  • Add column dup_checksum to task model class
  • As SHA 256 will be always 64 hex characters, restrict task.dup_checksum to String(64)
  • Upon generating checksum based on project configuration, set checksum value into task table.

@coveralls
Copy link

coveralls commented Dec 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12435058570

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 94.112%
Totals Coverage Status
Change from base Build 12402485829: 0.001%
Covered Lines: 17453
Relevant Lines: 18545
💛 - Coveralls

@dchhabda dchhabda requested a review from n00rsy December 20, 2024 17:23
n00rsy
n00rsy approved these changes Dec 20, 2024
View reviewed changes
Copy link

@n00rsy n00rsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dchhabda dchhabda merged commit daf1d50 into main Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n00rsy n00rsy n00rsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dchhabda @coveralls @n00rsy