-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spelling/grammar in pipeline notebook #1082
Fix spelling/grammar in pipeline notebook #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks @abigsmall - much appreciated.
Can you apply the missing style fix (e.g. by running pre-commit
?)
Regarding your the first sentence:
interference should actually be inference (ML inference).
Maybe we can change it to:
During interference, the augmenter only extracts those features that it has found as being relevant in the training phase. The classifier predicts the target using these features.
And regarding the second sentence: I like your proposal! Feel free to put it into the PR as well.
115cb15
to
e2e22cd
Compare
Noticed a few misspellings. Fixed a couple more based on PR feedback.
e2e22cd
to
3647821
Compare
Hi @nils-braun, thank you for the feedback! I had initially just made my changes via the GitHub web UI and wasn’t sure how to run
Let me know if I had to do something else! [1] terminal output after committing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @abigsmall! |
Noticed a few misspellings. I hope I’m not taking up valuable time by submitting this PR :).
There were a couple places I wasn’t sure what the intended meaning was, so I did not try to fix those, but would like to call them out below:
under Prediction:
under Separating the time series data containers: