-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better meta inferrence, to prevent indexing error while parquetting #877
base: main
Are you sure you want to change the base?
better meta inferrence, to prevent indexing error while parquetting #877
Conversation
…b.com/Apsylem/tsfresh into dask_on_chunk_fix_and_warning_disable
Codecov Report
@@ Coverage Diff @@
## main #877 +/- ##
==========================================
- Coverage 95.34% 95.19% -0.15%
==========================================
Files 18 18
Lines 1867 1872 +5
Branches 368 369 +1
==========================================
+ Hits 1780 1782 +2
- Misses 47 49 +2
- Partials 40 41 +1
Continue to review full report at Codecov.
|
I am sorry, this is my first pull request in a row and one of my first in general. Is there a better way to build upon my own changes, if the old pull request has not yet been accepted? I would aapreciate any remarks. |
Cool! Then thanks for taking your time and starting with open-source development! This is a good question and there are some options:
The absolut best option is to separate the changes into two independent PRs. That is not always possible though. |
I am sorry, but I don't see the whitespaces, the error report on my other pull request, showed the locations to be modified. here it says :
does this mean, the trailing whitespaces have already been removed ? |
Hi @Apsylem ! If you have followed our installation for developers description on the docu, you should have "pre-commit" installed, which will trigger fixing these style issues locally on your computer before you push to github. If you do not want to do this, you can at least call |
a unneccary indexing over cloumns in _feature_extraction_on_chunk_helper has been removed
but mainly, an option "taste_of_pandas_df" has been addet to dask_feature_extraction_on_chunk.
This example of the input is used to infer the correct meta in df.apply. This was neccecery due to missing and misleading index values while parquetting the data after tsfresh feature extraction. No Bug report has been filed for this issue.