You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In reth's invalid block hooks, we first compare the invalid block's BundleState to a re-executed version, then use serde_json to serialize BundleState and save it as JSON. Because the reverts are unsorted, this leads to equivalent BundleStates being seen as not equal. Instead, there should be a comparison API for Reverts that returns true if the reverts have the same contents, regardless of ordering.
The text was updated successfully, but these errors were encountered:
/// Compares two `Reverts` for equality, sorting the internal `Vec`s in place.pubfnunordered_eq(&mutself,other:&mutSelf) -> bool{// Sort inner vectors by Address in placeself.sort();
other.sort();// Compare sorted structures for equalityself.0 == other.0}
In reth's invalid block hooks, we first compare the invalid block's
BundleState
to a re-executed version, then useserde_json
to serializeBundleState
and save it as JSON. Because the reverts are unsorted, this leads to equivalentBundleState
s being seen as not equal. Instead, there should be a comparison API forReverts
that returnstrue
if the reverts have the same contents, regardless of ordering.The text was updated successfully, but these errors were encountered: