chore(revm): expose convenience cache state for preimages #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x00101010
changed the title
0x00101010
commented
Sep 6, 2024
| @@ -51,9 +51,8 @@ impl FunctionStack { | |||
|
|
|||
| /// Pops a frame from the stack and sets current_code_idx to the popped frame's idx. | |||
| pub fn pop(&mut self) -> Option<FunctionReturnFrame> { | |||
| self.return_stack.pop().map(|frame| { | |||
| self.return_stack.pop().inspect(|frame| { | |||
|
I would rather not have this function as State would show wrong changes if CacheDB is taken without taking bundle state. |
Thanks for the review @rakita! Any suggestions on how to take it out? Would it better to directly do it like https://github.com/paradigmxyz/reth/pull/10736/files#diff-7fbb0c1e65c92e8879aa308fee2538af673a2cd6d70f9b5b1103cf4d6554604dR386 or create a function like take_bundle_and_cache? The background story here is that in order to implement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
expose cache state for getting preimages, its initial user will be debug_execution_witness in reth. Reference PR here: https://github.com/paradigmxyz/reth/pull/10736/files