Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a null check #121

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Deprecated: md5): Passing null to
parameter #1 ($string) of type string is deprecated in /app/wordpress/content/mu-
plugins/endurance-page-cache.php on line 763

@arunshenoy99
Copy link
Member Author

arunshenoy99 commented Mar 19, 2024

@wpscholar please check if this makes sense. Wasn't able to replicate why $uri would be null.

Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunshenoy99 I think this makes sense, but let's move it before the $this->should_update_throttled_items = true; line. Doing so should shortcut additional processes that happen on shutdown.

@wpscholar wpscholar merged commit 2b4930e into bluehost:master Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants