Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recording timestamp with some audio codecs (#3969) (#4041) #4062

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 20, 2024

Fixes #3969
Fixes #4041

When a stream contained an Opus, MPEG-4 audio or AC3 track, timestamp in the segment file name was increasing at twice the speed.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.00%. Comparing base (d23fb08) to head (029ace0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/recorder/format_fmp4.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4062      +/-   ##
==========================================
+ Coverage   55.96%   56.00%   +0.04%     
==========================================
  Files         193      193              
  Lines       19689    19689              
==========================================
+ Hits        11018    11026       +8     
+ Misses       7827     7819       -8     
  Partials      844      844              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When a stream contained an Opus, MPEG-4 audio or AC3 track, timestamp in
the segment file name was increasing at twice the speed.
@aler9 aler9 force-pushed the fix/record-timestamp branch from 1dc2798 to 029ace0 Compare December 20, 2024 22:21
@aler9 aler9 merged commit f1e031c into main Dec 21, 2024
7 of 8 checks passed
@aler9 aler9 deleted the fix/record-timestamp branch December 21, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant