Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bookworm networking at once #3059

Merged
merged 6 commits into from
Jan 18, 2025
Merged

Fix Bookworm networking at once #3059

merged 6 commits into from
Jan 18, 2025

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Jan 14, 2025 •
edited
Loading

now using dhclient instead of networkmanager directly...
needs more testing

testing can be done by connecting to blueos via wifi, then

rm /roo/.config/cable-guy/settings.json  # to reset settings
# delete any network profiles on eth0
red-pill
nmcli -g NAME,DEVICE con show | grep eth0 | cut -d: -f1 | xargs -r nmcli con delete

@Williangalvani Williangalvani force-pushed the more_networking_tweaks branch 4 times, most recently from 99c805d to a16ec15 Compare January 14, 2025 12:51
@Williangalvani Williangalvani force-pushed the more_networking_tweaks branch 3 times, most recently from 90cc677 to c1138a7 Compare January 15, 2025 13:29
@Williangalvani Williangalvani marked this pull request as ready for review January 15, 2025 13:32
@Williangalvani Williangalvani force-pushed the more_networking_tweaks branch 4 times, most recently from 0c7df4b to 80c54d8 Compare January 16, 2025 00:50
@Williangalvani Williangalvani changed the title More networking experiments... Fix Bookworm networking at once Jan 16, 2025
@patrickelectric
Copy link
Member

@Williangalvani can you rebase this branch ?

@Williangalvani Williangalvani force-pushed the more_networking_tweaks branch 2 times, most recently from 712a1e4 to 094d159 Compare January 16, 2025 19:25
@patrickelectric
Copy link
Member

Clicking on "ask for dynamic IP" is deleting static IP.

@Williangalvani Williangalvani force-pushed the more_networking_tweaks branch 2 times, most recently from 4fea1df to aee8e7c Compare January 17, 2025 00:08
@patrickelectric
Copy link
Member

Clicking on "ask for dynamic IP" is deleting static IP.

still an issue

@Williangalvani Williangalvani force-pushed the more_networking_tweaks branch 2 times, most recently from 7984dc7 to d060960 Compare January 17, 2025 17:05
patrickelectric
patrickelectric approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge in master and work from there if necessary. It's already a great improvement

@patrickelectric patrickelectric merged commit b82a15e into bluerobotics:master Jan 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoMario109 JoaoMario109 JoaoMario109 approved these changes

@patrickelectric patrickelectric patrickelectric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Williangalvani @patrickelectric @JoaoMario109