Alert when Cockpit is minimized while vehicle is still armed #1379
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…armed Signed-off-by: Arturo Manzoli <[email protected]>
rafaellehmkuhl
requested changes
Oct 2, 2024
Comment on lines
+170
to
+179
| alertStore.pushAlert( | ||
| new Alert( | ||
| AlertLevel.Warning, | ||
| 'Warning: Vehicle armed and Cockpit minimized. Joystick inputs are stopped. Ensure vehicle safety.' | ||
| ) | ||
| ) | ||
| showElectronDesktopNotification( | ||
| 'Vehicle armed and Cockpit minimized. Joystick inputs are stopped. Ensure vehicle safety.' | ||
| ) | ||
| } |
There was a problem hiding this comment.
In this case the alert will be disabled if the user disabled the general voice alerts or warning alerts.
We should create add a "force" parameter to the pushAlert method and have a dedicated switch to disable this voice alert.
Comment on lines
+173
to
+178
| 'Warning: Vehicle armed and Cockpit minimized. Joystick inputs are stopped. Ensure vehicle safety.' | ||
| ) | ||
| ) | ||
| showElectronDesktopNotification( | ||
| 'Vehicle armed and Cockpit minimized. Joystick inputs are stopped. Ensure vehicle safety.' | ||
| ) |
There was a problem hiding this comment.
Messages are being replicated here. You can assign them to a variable and reuse. Will also consume less lines.
Also, could we make the message more explicit? Like "Cockpit minimized while vehicle is armed. Joystick inputs will not work. Ensure vehicle safety."?
|
You can use this to check if the application is running on Electron. Will work on both the Node process as well as the renderer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two alerts will be fired, voice (warning level) and electron desktop notification.
Closes #1377