web: v1: rest: mavlink: Add helper endpoint

[patrickelectric]

[joaoantoniocardoso]

I didn't get the idea behind this. Why are we adding an endpoint to get the default message?

[joaoantoniocardoso]

We are trying to keep the imports tidy by putting the crate:: imports after the 3rd party, separated by a blank line, as in:

use std::sync::Arc;

use anyhow::Result;

use crate::callbacks::{Callbacks, MessageCallback};

[joaoantoniocardoso]

Suggested change

	let json = serde_json::to_string_pretty(&MAVLinkJSON { header, message }).unwrap();
	let json = serde_json::to_string_pretty(&MAVLinkJSON { header, message })?;

[patrickelectric]

this operation will never fail.

[joaoantoniocardoso]

then:

Suggested change

	let json = serde_json::to_string_pretty(&MAVLinkJSON { header, message }).unwrap();
	let json = serde_json::to_string_pretty(&MAVLinkJSON { header, message }).expect("Should never fail here");

[joaoantoniocardoso]

Also, even if something never fails, it's still okay to use ? if we can

[patrickelectric]

But this will generate an invalid HTTP response that's not a json. Does not make more sense to add verbose code or a possible early return to a clear impossible operation. unwrap is there for a reason.

[joaoantoniocardoso]

But this will generate an invalid HTTP response that's not a json. Does not make more sense to add verbose code or a possible early return to a clear impossible operation. unwrap is there for a reason.

right, just use expect, then, so I won't get confused when reading the code in the future.

[patrickelectric]

This is a trivial operation, the type is known in compile time.

[joaoantoniocardoso]

Suggested change

	let error_json = serde_json::to_string_pretty(&error).unwrap();
	let error_json = serde_json::to_string_pretty(&error)?;

[patrickelectric]

This operation should never fail.

[patrickelectric]

I didn't get the idea behind this. Why are we adding an endpoint to get the default message?

This is a helper function, as exist in mavlink2rest for the user to use with the REST API, people don't have a serde serializer on their heads.

[joaoantoniocardoso]

2 more, 2 less.. later I'll clean up the unwraps to make the code easier to follow.

From what I can remember, there are many unwraps around, and differently from these two, some of those were not infallible.