Ensure app clip works even with starter-pack
#5664
Merged
+81
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
hailey/edge-case-starterpack - social-app PR #5664
Render
Destroyed
|
arcalinea
temporarily deployed
to
hailey/edge-case-starterpack - social-app PR #5664
Render
Destroyed
haileyok
commented
Oct 9, 2024
Comment on lines
+42
to
+49
| if (isWeb && !currentAccount) { | ||
| const getParams = new URLSearchParams(window.location.search) | ||
| const splash = getParams.get('splash') | ||
| if (splash === 'true') { | ||
| setShowLoggedOut(true) | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
Need a way to show the splash screen on web when signed out, so we'll just add a splash param that we can check.
haileyok
commented
Oct 9, 2024
Comment on lines
+34
to
+40
| React.useEffect(() => { | ||
| const getParams = new URLSearchParams(window.location.search) | ||
| const clip = getParams.get('clip') | ||
| if (clip === 'true') { | ||
| setShowClipOverlay(true) | ||
| } | ||
| }, []) |
There was a problem hiding this comment.
If we use clip=true on the splash, we should show the app download overlay.
haileyok
commented
Oct 9, 2024
Comment on lines
+89
to
+104
| switch host { | ||
| case "bsky.app": | ||
| if url.pathComponents.count == 4, | ||
| (url.pathComponents[1] == "start" || url.pathComponents[1] == "starter-pack") { | ||
| return true | ||
| } | ||
| return false | ||
| case "go.bsky.app": | ||
| if url.pathComponents.count == 2 { | ||
| return true | ||
| } | ||
| return false | ||
| default: | ||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
This will catch all possibilities: go.bsky.app, bsky.app/start, and bsky.app/starter-pack.
haileyok
commented
Oct 9, 2024
| self.webView?.load(URLRequest(url: url)) | ||
| } | ||
| } else { | ||
| self.webView?.load(URLRequest(url: URL(string: "https://bsky.app/?splash=true&clip=true")!)) |
There was a problem hiding this comment.
If anything other than a real starterpack link comes in, we want to just send the user to the splash and present the appclip overlay
arcalinea
temporarily deployed
to
hailey/edge-case-starterpack - social-app PR #5664
Render
Destroyed
haileyok
added a commit
that referenced
this pull request
Oct 9, 2024
(cherry picked from commit 2841944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unlikely edge case - which probably doesn't explain the thing Apple is seeing - that is possible to hit. The user would need to actually be signed in on web for this to be possible, since otherwise they'd get redirected to
/startrather than/starter-pack, but might as well fix it here.