-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PvaAbstractions and use them in SeqTable #522
Introduce PvaAbstractions and use them in SeqTable #522
Conversation
8bbdcdc
to
53d29d4
Compare
bffc983
to
d976d02
Compare
decided to include this in the PR for #310
Need to add json serialization.
Also finished a `PvaTable` type.
d976d02
to
e3b149c
Compare
e3b149c
to
42555ed
Compare
42555ed
to
e68976b
Compare
e68976b
to
c4bece5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, please could we have:
SignalType = TypeVar("SignalType", bool, int, ..., BaseModel)
class Signal:
def __init__(self, datatype: Optional[SignalType] = None):
check_one_of(datatype, SignalType)
...
I forgot that we wanted to take datatype
in Signal.__init__
so that we could create a Signal
with a type but no backend in create_children_from_annotations
, then fill it in on connect.
As per #310 (comment)
Still need to add datatype to the args of signal
Can we implement #310 (comment) in another issue/PR? This is already a very big change, and changing init/connect args for Additionally, I'd like to disallow |
Sounds like a good idea, let me know when this needs another review |
New issue here. I'm ready for a new review #562 |
# Wait for pre-delay then open shutter | ||
SeqTableRow( | ||
SeqTable.row( | ||
time1=in_micros(pre_delay), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... as we have an implicitly defined repeats
field that will have changes defaults from 1
to 0
. Are we lacking a test for this plan stub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have tests for this but at no point in them do we check on repeats
1aafbc0
to
49a047b
Compare
02c89b9
to
695e1db
Compare
…structured-data-for-tables
c2ac27c
to
b728640
Compare
Closes #442 and #310