Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows NotImplementedError #118

Closed
wants to merge 0 commits into from

Conversation

ziloka
Copy link

@ziloka ziloka commented Feb 13, 2023

When running the find command at least, proxybroker returns zero results and spams the terminal with NotImplementedError that traces back to pycares, the dep that aiodns uses.

The solution to this seems to be replace aiodns with dnspython, a dependency that is kept up to date.

@ziloka
Copy link
Author

ziloka commented Feb 13, 2023

Unrelated but aiohttp should be updated because on windows at least when executing the find command, python raises an NotImplementedError This doesn't seem to occur on linux.
Updated Dependencies because aiohttp 3.8.1 was causing issues

@ziloka
Copy link
Author

ziloka commented Feb 13, 2023

I don't know how to fix the test cases...

@bluet
Copy link
Owner

bluet commented Feb 25, 2023

@ziloka seems that you need to remove aiodns related codes in test and mock self._resolver.resolve() instead.

@bluet
Copy link
Owner

bluet commented Feb 25, 2023

linked issue #113

@ziloka
Copy link
Author

ziloka commented Feb 26, 2023

@ziloka seems that you need to remove aiodns related codes in test and mock self._resolver.resolve() instead.

haha I don't exactly know how to, thats the issue

@ziloka
Copy link
Author

ziloka commented Feb 26, 2023

assert await resolver.get_real_ext_ip() == '127.0.0.1'

This function means to get the external ip address.. right? But it tests for the internal ip address..

@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ziloka ziloka marked this pull request as draft May 29, 2023 15:14
@ziloka ziloka closed this Nov 12, 2023
Copy link

sonarcloud bot commented Nov 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bluet
Copy link
Owner

bluet commented Dec 5, 2023

hi @ziloka did you intend to close this issue because it's been fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants