-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix windows NotImplementedError #118
Conversation
74c8914
to
8017271
Compare
Unrelated but aiohttp should be updated because on windows at least when executing the find command, python raises an NotImplementedError This doesn't seem to occur on linux. |
I don't know how to fix the test cases... |
@ziloka seems that you need to remove |
linked issue #113 |
haha I don't exactly know how to, thats the issue |
proxybroker2/tests/test_resolver.py Line 46 in 5448377
This function means to get the external ip address.. right? But it tests for the internal ip address.. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
876d687
to
19e57ba
Compare
Kudos, SonarCloud Quality Gate passed! |
hi @ziloka did you intend to close this issue because it's been fixed? |
When running the find command at least, proxybroker returns zero results and spams the terminal with NotImplementedError that traces back to pycares, the dep that aiodns uses.
The solution to this seems to be replace aiodns with dnspython, a dependency that is kept up to date.