Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NotImplementedError on Windows Python 3.8+ #138

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

sweep-ai[bot]
Copy link

@sweep-ai sweep-ai bot commented Aug 17, 2023

Description

This PR fixes the NotImplementedError that occurs when running ProxyBroker from the command line interface (CLI) on Windows with Python 3.8 or higher. The issue is caused by a change in the default event loop policy in Python 3.8 on Windows, which does not support the add_reader method used by ProxyBroker. The fix sets the event loop policy to WindowsSelectorEventLoopPolicy on Windows to resolve the compatibility issue.

Summary of Changes

  • Added code to set the event loop policy to WindowsSelectorEventLoopPolicy in the proxybroker/cli.py file.
  • The code is placed at the top of the file, after the import statements.
  • The fix is only applied on Windows, as the issue does not occur on other platforms.
  • The fix ensures that the add_reader method is supported by the event loop policy, resolving the NotImplementedError issue.

Fixes #113.


To checkout this PR branch, run the following command in your terminal:

git checkout sweep/fix-notimplementederror-windows-python38

To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Aug 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bluet bluet merged commit 56e11a4 into master Aug 17, 2023
17 checks passed
@bluet bluet deleted the sweep/fix-notimplementederror-windows-python38 branch August 17, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotImplementedError on Windows Python 3.8+
1 participant