feat: validate tx onchain #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
approved these changes
Jul 15, 2024
unclezoro
reviewed
Jul 15, 2024
| return fmt.Errorf("failed to get on chain tx, err=%s", err.Error()) | ||
| } | ||
| if err := l.validateTx(onchainPack, tx); err != nil { | ||
| return fmt.Errorf("failed to validate tx, err=%s", err.Error()) |
There was a problem hiding this comment.
suggest panic if it does not match, because it is a very serious bug.
alexgao001
added a commit
to alexgao001/greenfield-relayer
that referenced
this pull request
Jul 15, 2024
alexgao001
added a commit
to alexgao001/greenfield-relayer
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
validate tx integrity against chain before persist into DB
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: