(op-geth) Add extra error info when meet an unexpected el sync #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish-nr
force-pushed
the
pbss_recover_chores
branch
2 times, most recently
from
e277e17
to
c45637b
Compare
krish-nr
force-pushed
the
pbss_recover_chores
branch
from
c45637b
to
e1be871
Compare
krish-nr
changed the title
welkin22
reviewed
Aug 2, 2024
krish-nr
force-pushed
the
pbss_recover_chores
branch
from
41efdeb
to
b0f19f4
Compare
krish-nr
force-pushed
the
pbss_recover_chores
branch
from
b0f19f4
to
2828964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When op-geth exits due to certain exceptional circumstances and the truncate operation results in the deletion of head data, the block-by-block insertion requests from op-node will trigger an EL sync in geth. This PR addresses this situation.
related op-node pr: https://github.com/bnb-chain/opbnb/pull/222
Rationale
Instead of ignoring the unexpected EL sync triggers, specific errors are returned. op-node will handle them based on the state.
Example
N/A
Changes