fix: remove unnecessary newRPCTransactionFromBlockHash function[BNB-21] #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
approved these changes
Jan 5, 2024
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 6, 2024
* txdag: add excluded flag; mvstates: generate txdag with excluded flag; * pevm: support txdag with excluded tx; * blockchain: opt txdag file mode; * pevm: fix dispatch bugs; * pevm: opt txdag dispatch; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 7, 2024
* txdag: add excluded flag; mvstates: generate txdag with excluded flag; * pevm: support txdag with excluded tx; * blockchain: opt txdag file mode; * pevm: fix dispatch bugs; * pevm: opt txdag dispatch; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 13, 2024
* txdag: add excluded flag; mvstates: generate txdag with excluded flag; * pevm: support txdag with excluded tx; * blockchain: opt txdag file mode; * pevm: fix dispatch bugs; * pevm: opt txdag dispatch; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Sep 25, 2024
* txdag: add excluded flag; mvstates: generate txdag with excluded flag; * pevm: support txdag with excluded tx; * blockchain: opt txdag file mode; * pevm: fix dispatch bugs; * pevm: opt txdag dispatch; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Oct 11, 2024
* txdag: add excluded flag; mvstates: generate txdag with excluded flag; * pevm: support txdag with excluded tx; * blockchain: opt txdag file mode; * pevm: fix dispatch bugs; * pevm: opt txdag dispatch; --------- Co-authored-by: galaio <[email protected]>
welkin22
pushed a commit
that referenced
this pull request
Oct 22, 2024
* txdag: add excluded flag; mvstates: generate txdag with excluded flag; * pevm: support txdag with excluded tx; * blockchain: opt txdag file mode; * pevm: fix dispatch bugs; * pevm: opt txdag dispatch; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Nov 14, 2024
* txdag: add excluded flag; mvstates: generate txdag with excluded flag; * pevm: support txdag with excluded tx; * blockchain: opt txdag file mode; * pevm: fix dispatch bugs; * pevm: opt txdag dispatch; --------- Co-authored-by: galaio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove unnecessary
newRPCTransactionFromBlockHashfunction. usenewRPCTransactionFromBlockIndexinstead.Delete the redundant tx parameter of
newRPCTransactionFromBlockIndex, which makes the function more difficult to understand.Rationale
the
newRPCTransactionFromBlockHash()function no longer uses the hash parameter, instead, it simply calls thenewRPCTransactionFromBlockIndex()function. This renders thenewRPCTransactionFromBlockHash()function redundant and confusing, as it is no longer related to "block hash".Example
none
Changes
Notable changes:
newRPCTransactionFromBlockHashfunction.newRPCTransactionFromBlockIndex, which makes the function more difficult to understand.