feat: support getting withdrawal proof on pbss #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeylichang
force-pushed
the
pbss_wp
branch
8 times, most recently
from
4dff2fd
to
ffbfda8
Compare
joeylichang
changed the title
joeylichang
added
enhancement
joeylichang
changed the title
joeylichang
force-pushed
the
pbss_wp
branch
4 times, most recently
from
e53be06
to
17caa0e
Compare
joeylichang
force-pushed
the
pbss_wp
branch
4 times, most recently
from
0f73d36
to
789c943
Compare
welkin22
reviewed
Apr 3, 2024
krish-nr
previously approved these changes
Apr 7, 2024
joeylichang
force-pushed
the
pbss_wp
branch
2 times, most recently
from
b6252cc
to
c81711e
Compare
will-2012
previously approved these changes
Apr 8, 2024
owen-reorg
reviewed
Apr 8, 2024
joeylichang
force-pushed
the
pbss_wp
branch
2 times, most recently
from
225b376
to
92e7445
Compare
joeylichang
changed the title
joeylichang
commented
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes a solution that makes it possible to obtain proof of withdrawal in PBSS.
NodeBufferList consists of a NodeCache list and a BaseNodeBuffer. A NodeCache is used to store the diffLayers committed. The diffLayers in one NodeCache is limited to 1800. When a NodeCache is full, another new NodeCache is initialized and placed at the top of the list. In the background, the NodeCache from the end of the list is regularly inserted into the BaseNodeBuffer. When the BaseNodeBuffer reaches 256M, it will be flushed to the backend database. There are at least two NodeCaches in the list, which ensure that there are at least 3600 diffLayers in the memory.
Rationale
PBSS can only support the world state of the recent last 129 (128 difflayers + 1 disklayer) blocks’ state data; while getting withdrawal proof needs the world state of the last block divisible by 3600, which MUST be kept.
Example
If you want to use nodebufferlist, you can use the
--pathdb.nodebuffer listflag.--pathdb.nodebufferis set type of trienodebuffer to cache trie nodes in disklayer('list', 'sync', or 'async'), which default is async. async is double nodebuffer for flushing db in background. sync is the community’s native nodebuffer, which block flushing db.--pathdb.syncChanges
Notable changes: