bugfix: fix Resubscribe deadlock when unsubscribing after inner sub ends #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See ethereum-optimism/optimism#8086
We encountered the same issue, where a deadlock caused op-node to be unable to gracefully shutdown.
Therefore, we need to introduce this fix as soon as possible to resolve our current op-node issue.
Rationale
op-nodeuses theResubscribeErrmethod, but the size of the unsubscribed channel is 0, causing a deadlock during the shutdown process.Example
none
Changes
Notable changes:
ResubscribeErrmethod issue