feat(txpool): improve demotion unexecutable transactions #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
approved these changes
May 28, 2024
owen-reorg
changed the title
bnoieh
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It improves the demotion of un-executable transactions in txpool, to increase the throughput of txpool.
Rationale
Demotion contributes a lot to the latency of the runReorg() procedure, with a portion of nearly 30% to 40%. And, it gets worse when the number of pending transactions grows, since every time the txpool demotes un-executable transactions, it iterator every transaction in the pool to decide whether to demote it or not.
Changes
Notable changes: