improve Pending() of txpool to reduce the latency when miner worker committing transactions #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
pushed a commit
to owen-reorg/op-geth
that referenced
this pull request
Apr 25, 2024
…head miner: Account for L1 Info Deposit gas usage in the pending pool
owen-reorg
reviewed
May 28, 2024
added 4 commits
May 30, 2024 17:04
…m:andyzhang2023/op-geth into 1mgas-txpool-v0.3.0-pending
owen-reorg
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
improve Pending() of txpool to reduce the latency when the miner worker commits transactions, by maintaining a copy of pending transactions for the worker, to avoid lock race condition.
Rationale
The miner worker has limited time to commit transactions, and it wastes too much to call Pending() to fetch transactions from the mem pool, which sometimes costs hundreds of milliseconds.
Changes
Notable changes: