feat: eliminate the impact caused by l2-reorg by scanning finalized blocks only #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendanzhentan
changed the title
To eliminate the impact caused by l2-reorg, the l2-scanner choose to only scan the finalized blocks. Once a l2-block has been finalized, it can be confirmed that it will not be reorg. Previously, we configured Misc.ConfirmBlocks to eliminate L2 reorg impact, but finalized block tags are more robust. So this PR removes Misc.ConfirmBlocks also.
bendanzhentan
force-pushed
the
avoid-l2-reorg-impact
branch
from
1bac8dc
to
6e0794e
Compare
bendanzhentan
changed the base branch from
develop
to
fix-query-filter-failure-reason
owen-reorg
approved these changes
Dec 6, 2023
bendanzhentan
changed the base branch from
fix-query-filter-failure-reason
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To eliminate the impact caused by l2-reorg, the l2-scanner choose to only scan the finalized blocks. Once a l2-block has been finalized, it can be confirmed that it will not be reorg.
Previously, we configured Misc.ConfirmBlocks to eliminate L2 reorg impact, but finalized block tags are more robust. So this PR removes Misc.ConfirmBlocks also.