fix: query failure_reason = "" #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendanzhentan
force-pushed
the
develop
branch
from
36c2a78
to
e31ae56
Compare
owen-reorg
reviewed
Dec 6, 2023
| @@ -93,7 +93,7 @@ func ProcessUnprovenBotDelegatedWithdrawals(ctx context.Context, log log.Logger, | |||
| maxBlockTime := time.Now().Unix() - cfg.Misc.ProposeTimeWindow | |||
|
|
|||
| unprovens := make([]core.L2ContractEvent, 0) | |||
| result := db.Order("id asc").Where("proven = false AND block_time < ? AND failure_reason IS NULL", maxBlockTime).Limit(limit).Find(&unprovens) | |||
| result := db.Order("id asc").Where("proven = false AND block_time < ? AND failure_reason = ''", maxBlockTime).Limit(limit).Find(&unprovens) | |||
There was a problem hiding this comment.
Why do this change? Seems the schema still allows NULL.
There was a problem hiding this comment.
This is related to the Go type definition. The failure reason is defined as a Go string instead of a string. That makes L2ContractEvent.FailureReason default to be empty string "" but not nil. Due to this, the failure reason inserted is "" not NULL.
type L2ContractEvent struct {
...
FailureReason string `gorm:"type:text"`
}There was a problem hiding this comment.
I am gonna close this PR and fix this issue by changing L2ContractEvent.FailureReason to *string.
bendanzhentan
force-pushed
the
develop
branch
from
e31ae56
to
5908c6b
Compare
|
I am gonna close this PR and fix this issue by changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing if a ‘text’ type database field is empty, use
= '' instead ofIS NULL.