fix: locate log within receipt using logIndex #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendanzhentan
changed the base branch from
main
to
avoid-reprocessing-withdrawals
owen-reorg
approved these changes
Dec 15, 2023
Log.LogIndex is indexed at the block level, so it's incorrect to locate a log using receipt.Logs[log.LogIndex]. Instead, we should traverse through receipt.Logs and find the matching log based on log.LogIndex.
bendanzhentan
force-pushed
the
fix-log-index
branch
from
a601215
to
44fa007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log.LogIndexis indexed at the block level, so it’s incorrect to locate a log usingreceipt.Logs[log.LogIndex].Instead, we should traverse through
receipt.Logsand find the matching log based onlog.LogIndex.