Merge develop into main branch #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To eliminate the impact caused by l2-reorg, the l2-scanner choose to only scan the finalized blocks. Once a l2-block has been finalized, it can be confirmed that it will not be reorg. Previously, we configured Misc.ConfirmBlocks to eliminate L2 reorg impact, but finalized block tags are more robust. So this PR removes Misc.ConfirmBlocks also.
* contracts: limit range of _delegationFee for setDelegationFee * contracts: remove receive() and fallback() * contracts: replace transferFrom to SafeERC20.safeTransferFrom * Update contracts/src/L2StandardBridgeBot.sol Co-authored-by: Owen <[email protected]> --------- Co-authored-by: Owen <[email protected]>
* fix: botDelegatedWithdrawToEvent transaction should have at least 6 logs * chore: check storage proof size
* ci: add .github/workflows/publish-docker-image.yaml * fix: docker run
* bindings: add bindings/L2StandardBridgeBot.go * feat: filter withdrawals by configured filters * feat: record filtered reason as failure reason * config: refine config type * chore: apply review suggestions * chore: update comments for modified configs
* fix: avoid re-processing withdrawals 1. check pending nonce and chain nonce before processing 2. check recently processed using local records before processing * feat: update db types `BotDelegatedWithdrawal` 1. Rename L2ContractEvent to BotDelegatedWithdrawal 2. Add unique constraint idx_bot_delegated_withdrawals_transaction_hash_log_index_key 3. Add new field `InitiatedBlockNumber int64` to indicate the L2 number of initiated withdrawal transaction 3. Add new fields `ProvenTime *Time` and `FinalizedTime *Time` to indicate the local time of L1 proven transaction and finalized transaction 4. Modify the `FailureReason` to type `FailureReason *string` * improve: compare timings of proven and finalized more precisely 1. Determine the proven timing based on the `L2OutputOracle.latestBlockNumber` 2. Determine the finalized timing based on the db `proven_time` * bindings: update binding * feat: manage nonce locally * config: update bot contract
Log.LogIndex is indexed at the block level, so it's incorrect to locate a log using receipt.Logs[log.LogIndex]. Instead, we should traverse through receipt.Logs and find the matching log based on log.LogIndex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.