[TMP] Just for code review #42

unclezoro · 2024-07-04T07:17:05Z

Description

add a description of your changes here...

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

add each change in a bullet point here
...

Potential Impacts

add potential impacts for other components here
...

…uctions (#1245)

Bumps [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1) from 0.28.2 to 0.29.0. - [Changelog](https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md) - [Commits](rust-bitcoin/rust-secp256k1@secp256k1-0.28.2...secp256k1-0.29.0) --- updated-dependencies: - dependency-name: secp256k1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

… (#1243) * feat(interpreter): remove SPEC generic from gas calculation functions * feat(interpreter): make most gas cost calculation functions `const` * set_final_refund * unused * fix: optimism * chore: use `is_london: bool` instead of `SpecId` in `Gas::set_final_refund`

* feat: alloydb * chore: turn on needed deps for test * derive * correct address * chore: remove arc * feat: actually make Transport and Network generic to accept any transport or network * chore: condense markers into one, more idiomatic

* fix typo * fix typo

* check without microbench * cleanup

* feat: add modifies_memory macro * refactor

* fix examples->generate_block_traces reuse TracerEip3155.gas_inspector issue * fmt code * clear the eip3155 tracer state so that it can be used in next transaction * print summary and clean state when create_end * update documentation * fix left nits * add cancun upgrade block number * remove outdated doc * remove outdated doc * remove empty file * TS is unit used to trigger the hardork --------- Co-authored-by: rakita <[email protected]>

* eof * feat(EOF): Header decoder * EofBody decode * disable eof deprecated opcodes * add eof instructions * temp tests * rjump instructions * eof rjump with tests * EOF bytecode * callf, retf, jumpf * tests for callf,retf,jumpf * small rename * add dataload, dataloadn and datacopy opcodes * refactor calls * blueprint for creates * eof create inputs * some wip * add eofcreate structs and exccall flow * wip eofcreate code flow and handlers * fix tests * eof creates * refactor eofcreate a little * some work on extcall * feat: refactor simplify CallInput, eof extcalls * feat: restructure OpCode and add stack input/output num * add flags for stack_io and not_eof * wip eof verification * wip validation * EOF Bytecode validity * insturction and jump validation seems good * merged eof validate function * EOP test runner, fex fixes * RETURNDATALOAD, fix call bugs, refactor gas warm/cold calc * debug session, rjumpv imm fix * fixing validation bugs, bytecode decoder for EOF in revme * pass most of validation tests * bounds check moved to decode * Fix merge compilation, fmt * TXCREATE work * remove training wheels, panic on eof * test fix and std * std * fix test * fix valgrind * fix tests * clippy * removed checked logic * small change * no std revm-test * check pending TODOs * build check no_std * doc * chore: move some files. cleanup comments * fix fmt,clippy and compile error

…(#1285)

* feat: add flag to force hashbrown usage * misc: propagate hashbrown feature flag

* feat(revm): make `FrameOrResult` serializable This commit make all structs under `FrameOrResult` serializable, which is useful when trying to save execution state inside an inspector during transaction execution. The modified structs include: * revm: `FrameOrResult`, `FrameResult`, `Frame`, `FrameData`, `CallFrame`, `CreateFrame`, `JournalCheckpoint` * interpreter: `BytecodeLocked`, `Contract`, `Gas`, `CreateOutcome`, `CallOutcome`, `Interpreter` * style(interpreter): make clippy happy * fix(interpreter): fix missing conflict * style(interpreter): make clippy happy

…d` (#1286)

* fix: correct some stack IO * chore: remove dead code

Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.81 to 1.0.82. - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.81...1.0.82) --- updated-dependencies: - dependency-name: anyhow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [bitflags](https://github.com/bitflags/bitflags) from 2.5.0 to 2.6.0. - [Release notes](https://github.com/bitflags/bitflags/releases) - [Changelog](https://github.com/bitflags/bitflags/blob/main/CHANGELOG.md) - [Commits](bitflags/bitflags@2.5.0...2.6.0) --- updated-dependencies: - dependency-name: bitflags dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde](https://github.com/serde-rs/serde) from 1.0.203 to 1.0.204. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.203...v1.0.204) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.117 to 1.0.120. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.117...v1.0.120) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: use `kzg-rs` * fix: use `c-kzg` by default in std env * refactor: feature gate by `c-kzg` * fix: use published crate * fix: `kzg-rs` import * feat: use `cfg_if` for `kzg-rs` imports * feat: use `kzg-rs` * fix: `kzg-rs` import * chore: add `kzg-rs` feature to revm-interpreter * fix: check kzg-rs enable in revm/precompile * fix: kzg-rs include once_cell and derive_more in primitives, update feature tags * Update crates/primitives/src/lib.rs * Update crates/precompile/src/lib.rs * Update crates/primitives/Cargo.toml * Update crates/revm/Cargo.toml * Update crates/precompile/Cargo.toml * Update crates/primitives/src/lib.rs --------- Co-authored-by: rakita <[email protected]>

…1600) * chore: Refactor code, and check is precompile for create colision * remove some TODOs for eofcreate nonce

* fix(EOF): MIN_CALLEE_GAS light failure, static-mode check * clear buffer * readd min caller gas

* refactor: group optimism invalid txn errors * Update crates/primitives/src/result.rs

* fix(eof): Use cfg code size limit for eofcreate * Update crates/revm/src/context/inner_evm_context.rs * simplify

* feat(EOF): Bytecode::new_raw supports EOF, new_raw_checked added * Use from abbreviation

Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.61 to 1.0.62. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.61...1.0.62) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [alloy-primitives](https://github.com/alloy-rs/core) from 0.7.6 to 0.7.7. - [Release notes](https://github.com/alloy-rs/core/releases) - [Changelog](https://github.com/alloy-rs/core/blob/main/CHANGELOG.md) - [Commits](alloy-rs/core@v0.7.6...v0.7.7) --- updated-dependencies: - dependency-name: alloy-primitives dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [alloy-sol-macro](https://github.com/alloy-rs/core) from 0.7.6 to 0.7.7. - [Release notes](https://github.com/alloy-rs/core/releases) - [Changelog](https://github.com/alloy-rs/core/blob/main/CHANGELOG.md) - [Commits](alloy-rs/core@v0.7.6...v0.7.7) --- updated-dependencies: - dependency-name: alloy-sol-macro dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [alloy-sol-types](https://github.com/alloy-rs/core) from 0.7.6 to 0.7.7. - [Release notes](https://github.com/alloy-rs/core/releases) - [Changelog](https://github.com/alloy-rs/core/blob/main/CHANGELOG.md) - [Commits](alloy-rs/core@v0.7.6...v0.7.7) --- updated-dependencies: - dependency-name: alloy-sol-types dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(eip7702): Add tests and fix some bugs * passing tests * remove disabling of state clear, fix eip7702 * fmt/clippy rm comments * add CI for eof and prague tests * code cleanup * fmt

* feat(eof): cli eof-validation * cleanup, remove old tests * rm eof verification test

* chore: bump alloy deps * add From

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* bump versions for primitives * bump revm

chore: merge upstream v12.1.0(v40)

rakita and others added 30 commits April 2, 2024 22:08

chore: fix publish revm-precompile (#1258)

223f6cd

feat(interpreter): test Host object-safety, allow dyn Host in instr…

8af9531

…uctions (#1245)

feat(interpreter): derive Eq for InterpreterAction (#1262)

4d64bbc

chore: add and use EvmContext::take_error (#1264)

5e730a6

feat(db): Introduce alloydb (#1257)

af56651

* feat: alloydb * chore: turn on needed deps for test * derive * correct address * chore: remove arc * feat: actually make Transport and Network generic to accept any transport or network * chore: condense markers into one, more idiomatic

minor typo fix in docs (#1266)

eee0541

* fix typo * fix typo

chore(ci): use more stable rust toolchain plugin (#1269)

d3db49d

chore: revert snailtracer without microbench (#1259)

c961887

* check without microbench * cleanup

perf(interpreter): use pop_top! where possible (#1267)

c1eb0e6

Add the modifies_memory macro (#1270)

11e819c

* feat: add modifies_memory macro * refactor

feat: pass rand feature to alloy_primitives (#1276)

d06f5d0

feat(revme): add --keep-going to statetest command (#1277)

cf96ce8

docs(inspectors): change serde to serde-json for TracerEip3155 …

cfc4511

…(#1285)

feat: add flag to force hashbrown usage (#1284)

e0f72a0

* feat: add flag to force hashbrown usage * misc: propagate hashbrown feature flag

feat: add Bytecode::original_bytecode_slice to match `BytecodeLocke…

7957c02

…d` (#1286)

fix: Drops check for .json when testing a single file (#1301)

5d25c4d

fix: correct some stack IO (#1302)

f4f4745

* fix: correct some stack IO * chore: remove dead code

chore(interpreter): rename wrapping_* opcodes (#1306)

72356e3

chore: fix some warnings (#1305)

cc1b9f7

perf(interpreter): remove EOF branch in CODE{SIZE,COPY} (#1308)

9cfd144

chore(interpreter): rename some macros (#1304)

688c36c

docs: fix the Instruction Table link (#1337)

41beddf

chore: weekly dependabot (#1325)

43199dd

chore: update GitHub Actions to Node 20 (#1338)

e987d2b

dependabot bot and others added 29 commits August 2, 2024 02:26

chore: Refactor code, and check if precompile for create collision (#…

aae840e

…1600) * chore: Refactor code, and check is precompile for create colision * remove some TODOs for eofcreate nonce

fix(EOF): MIN_CALLEE_GAS light failure, static-mode check (#1599)

48409bc

* fix(EOF): MIN_CALLEE_GAS light failure, static-mode check * clear buffer * readd min caller gas

refactor: load_account -> warm_preloaded_addresses (#1584)

19cb8a8

fix: missing kzg_settings if kzg-rs feature enabled (#1601)

c5544b3

test(GeneralState): skip fewer specs (#1603)

939cef6

refactor: group optimism invalid txn errors (#1604)

5bc25e6

* refactor: group optimism invalid txn errors * Update crates/primitives/src/result.rs

fix(EOF): Use cfg code size limit for eofcreate (#1606)

a4c91df

* fix(eof): Use cfg code size limit for eofcreate * Update crates/revm/src/context/inner_evm_context.rs * simplify

feat(EOF): Bytecode::new_raw supports EOF, new_raw_checked added (#1607)

85d1d90

* feat(EOF): Bytecode::new_raw supports EOF, new_raw_checked added * Use from abbreviation

fix: allow non-static lifetime in HandleRegisterBox (#1608)

e5d84f8

feat: pass interpreter into Inspector::log (#1610)

ac80c2d

fix: correctly calculate eofcreate address (#1619)

5d37d43

fix(eip7702): Add tests and fix some bugs (#1605)

1a216cc

* fix(eip7702): Add tests and fix some bugs * passing tests * remove disabling of state clear, fix eip7702 * fmt/clippy rm comments * add CI for eof and prague tests * code cleanup * fmt

feat(eof): cli eof-validation (#1622)

6b28fb8

* feat(eof): cli eof-validation * cleanup, remove old tests * rm eof verification test

chore: bump alloy deps (#1623)

f6b6f3e

* chore: bump alloy deps * add From

chore: release (#1620)

5d9b95a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

bump: main changelog update (#1626)

aa78bc8

fix(eof): don't fail if offset overflows usize (#1627)

cb8b75a

chore(EOF): Use Bytecode::new_legacy (#1628)

0de9b83

chore: bump main changelog (#1630)

7d5cc2d

chore: bump versions bcs of primitives (#1631)

bc6116b

* bump versions for primitives * bump revm

Merge pull request #51 from bnb-chain/merge/upstream_v12.1.0

0161a27

chore: merge upstream v12.1.0(v40)

unclezoro closed this Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TMP] Just for code review #42

[TMP] Just for code review #42

unclezoro commented Jul 4, 2024

[TMP] Just for code review #42

[TMP] Just for code review #42

Conversation

unclezoro commented Jul 4, 2024

Description

Rationale

Example

Changes

Potential Impacts