Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return empty bytes when bls validation failed #68

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

pythonberg1997
Copy link
Contributor

Description

This pr is to fix an issue in BLS_SIGNATURE_VALIDATION precompile contract

Rationale

The function should return empty bytes rather than 0x00

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Potential Impacts

  • add potential impacts for other components here
  • ...

Copy link
Contributor

Valgrind Results:

==6520== Cachegrind, a cache and branch-prediction profiler
==6520== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==6520== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==6520== Command: target/release/snailtracer
==6520== 
--6520-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.80112177s
==6520== 
==6520== I   refs:      427,738,238
==6520== I1  misses:          3,169
==6520== LLi misses:          2,832
==6520== I1  miss rate:        0.00%
==6520== LLi miss rate:        0.00%
==6520== 
==6520== D   refs:      204,083,474  (132,274,349 rd   + 71,809,125 wr)
==6520== D1  misses:        340,695  (    200,734 rd   +    139,961 wr)
==6520== LLd misses:        137,639  (      4,347 rd   +    133,292 wr)
==6520== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==6520== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==6520== 
==6520== LL refs:           343,864  (    203,903 rd   +    139,961 wr)
==6520== LL misses:         140,471  (      7,179 rd   +    133,292 wr)
==6520== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@pythonberg1997 pythonberg1997 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into develop with commit 7a4d6dd Aug 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants