feat: makes revm sp1 compatible through feature controlling #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhAnGeek
force-pushed
the
feat--makes-revm-sp1-compatible-through-feature-controlling
branch
7 times, most recently
from
3de530c
to
39dde2a
Compare
ZhAnGeek
force-pushed
the
feat--makes-revm-sp1-compatible-through-feature-controlling
branch
from
39dde2a
to
52c7199
Compare
ZhAnGeek
force-pushed
the
feat--makes-revm-sp1-compatible-through-feature-controlling
branch
2 times, most recently
from
eb6eb74
to
88c3a49
Compare
ZhAnGeek
force-pushed
the
feat--makes-revm-sp1-compatible-through-feature-controlling
branch
from
88c3a49
to
b8d59fa
Compare
ZhAnGeek
commented
Nov 11, 2024
| @@ -408,7 +408,7 @@ fn encode_light_block_validation_result( | |||
| let mut output = | |||
| vec![0; (VALIDATE_RESULT_METADATA_LENGTH + consensus_state_bytes.len() as u64) as usize]; | |||
| output[0] = if validator_set_changed { 1 } else { 0 }; | |||
| output[24..32].copy_from_slice(consensus_state_bytes.len().to_be_bytes().as_ref()); | |||
| output[24..32].copy_from_slice((consensus_state_bytes.len() as u64).to_be_bytes().as_ref()); | |||
There was a problem hiding this comment.
Compatibility for 32-bit system, risv32 running panic for this line due to mismatch len
crates/precompile/src/lib.rs
Outdated
| @@ -3,6 +3,8 @@ | |||
| //! Implementations of EVM precompiled contracts. | |||
| #![cfg_attr(not(test), warn(unused_crate_dependencies))] | |||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
| #![allow(unused_mut)] | |||
| #![allow(unused_crate_dependencies)] | |||
There was a problem hiding this comment.
We'd better remove this to keep deps clean
ZhAnGeek
force-pushed
the
feat--makes-revm-sp1-compatible-through-feature-controlling
branch
4 times, most recently
from
ee7ce1b
to
14d8659
Compare
ZhAnGeek
force-pushed
the
feat--makes-revm-sp1-compatible-through-feature-controlling
branch
from
14d8659
to
3dff0d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
makes revm sp1 compatible through feature controlling
Rationale
adapt revm to be compilable for risv32 and so as to prove opbnb blocks
Changes