Added cardinal and normal number options for seasons. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -285,6 +285,8 @@ void format(char *buf, const char* fmt, struct disc_time dt) | |||
| case 'a': wibble=day_short[dt.yday%5]; break; | |||
| case 'B': wibble=season_long[dt.season]; break; | |||
| case 'b': wibble=season_short[dt.season]; break; | |||
| case 'u': sprintf(snarf, "%u", dt.season+1); wibble=snarf; break; | |||
There was a problem hiding this comment.
"%d" instead of "%u" as per cases 'd' and 'e'? Don't need unsigned integer in this case, do we?
|
Should we add zero-padding option? (%z), so this: "%d/%u/%Y" produces: 25/04/3180 (for today's date). |
|
Yes, zero padding would be really good idea. |
|
Numbers instead of words for seasons! How ingenious. Please fix the format specifier to match the sign of the type and add zero padding if you like. |
|
Aha, this is exactly what I was doing just now. I disagree that we need to zero pad anything that can't exceed nine though. That's the only reason that ISO does it, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.