Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some temporal methods #3856

Merged
merged 15 commits into from
Aug 13, 2024
Merged

add some temporal methods #3856

merged 15 commits into from
Aug 13, 2024

Conversation

jasonwilliams
Copy link
Member

@jasonwilliams jasonwilliams commented May 15, 2024 •
edited
Loading

Adds methods to yearMonth and monthDay

Relies on boa-dev/temporal#44

@jasonwilliams jasonwilliams added the enhancement New feature or request label May 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 48,212 48,212 0
Passed 43,264 43,346 +82
Ignored 1,413 1,413 0
Failed 3,535 3,453 -82
Panics 0 0 0
Conformance 89.74% 89.91% +0.17%
Fixed tests (130): 
test/staging/Temporal/Regex/old/plainyearmonth.js (previously Failed)
test/staging/Temporal/Regex/old/plainmonthday.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/options-object.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/observable-get-overflow-argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/name.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/builtin.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/day/branding.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/day/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toString/branding.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toString/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/monthCode/branding.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/monthCode/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/calendarId/branding.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/calendarId/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-expand.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-halfCeil.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-halfFloor.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-ceil.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-floor.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-halfTrunc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-halfEven.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingincrement-minutes.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-halfExpand.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/rounding-cross-midnight.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/options-object.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/largestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/result-sub-second.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/largestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/argument-object.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/options-ignored.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/argument-object.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/argument-duration.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/argument-string-negative-fractional-units.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/argument-string-fractional-units-rounding-mode.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/options-ignored.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/calendar-undefined.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-trailing-junk.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/name.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/options-undefined.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/builtin.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/monthsInYear/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/monthsInYear/basic.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/month/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/daysInMonth/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/daysInMonth/basic.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/daysInYear/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/daysInYear/basic.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/inLeapYear/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/inLeapYear/basic.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/year/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/options-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/argument-mixed-sign.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/limits.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/non-integer-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/calendarname-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/calendarname-never.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/calendarname-auto.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/options-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/calendarname-undefined.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/calendarname-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/argument-timezone-field.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/argument-missing-fields.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/argument-calendar-field.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/monthCode/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/options-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/builtin-calendar-no-array-iteration.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/argument-mixed-sign.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/non-integer-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/calendarId/branding.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/largestunit-default.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/rounding-relative.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/options-object.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/weeks-months.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/smallestunit-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/largestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/days-in-month.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/largestunit-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/roundingincrement-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/days-in-year.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/largestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/largestunit-smallestunit-combinations.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/sign-conflict-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/negated/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/negated/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/subseconds.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/hour-overflow.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/hour-overflow.js (previously Failed)
test/intl402/Temporal/PlainMonthDay/from/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainMonthDay/prototype/with/fields-missing-properties.js (previously Failed)
test/intl402/Temporal/PlainYearMonth/canonicalize-calendar.js (previously Failed)
Broken tests (48): 
test/built-ins/Temporal/Instant/prototype/until/roundingmode-expand.js (previously Passed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfCeil.js (previously Passed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfFloor.js (previously Passed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-ceil.js (previously Passed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-floor.js (previously Passed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfTrunc.js (previously Passed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfEven.js (previously Passed)
test/built-ins/Temporal/Instant/prototype/until/roundingmode-halfExpand.js (previously Passed)
test/built-ins/Temporal/PlainMonthDay/from/fields-missing-properties.js (previously Passed)
test/built-ins/Temporal/PlainMonthDay/prototype/toString/length.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-expand.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfCeil.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-with-time-designator.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/balance-negative-time-units.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfFloor.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-ceil.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-floor.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfTrunc.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfEven.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfExpand.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/basic.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/from/fields-missing-properties.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-number.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/from/options-invalid.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/prototype/toString/length.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/balance-negative-result.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-expand.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfCeil.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/round-negative-result.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/balance-subseconds.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfFloor.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-ceil.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-floor.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfTrunc.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfEven.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfExpand.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/add/balance-negative-result.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/add/balance-negative-time-units.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/add/argument-string-negative-fractional-units.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/add/argument-string-fractional-units-rounding-mode.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/subtract/balance-negative-result.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/subtract/balance-negative-time-units.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/subtract/argument-string-fractional-units-rounding-mode.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/prototype/until/balance-negative-time-units.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/prototype/until/balance-negative-duration.js (previously Passed)
test/intl402/Temporal/PlainMonthDay/from/fields-missing-properties.js (previously Passed)
test/intl402/Temporal/PlainMonthDay/from/fields-underspecified.js (previously Passed)
test/intl402/Temporal/PlainYearMonth/from/one-of-era-erayear-undefined.js (previously Passed)

nekevss
nekevss reviewed May 16, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little early feedback 😄

core/engine/src/builtins/temporal/plain_year_month/mod.rs Outdated Show resolved Hide resolved
@jasonwilliams
Copy link
Member Author

linked to boa-dev/temporal#44

@jasonwilliams jasonwilliams marked this pull request as ready for review May 24, 2024 16:11
nekevss
nekevss reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PartialDuration update looks good to me! Had a couple more comments around MonthDay. 😄

core/engine/src/builtins/temporal/duration/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/duration/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/plain_month_day/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/duration/mod.rs Show resolved Hide resolved
@nekevss
Copy link
Member

nekevss commented Jul 31, 2024

Was double checking this. I think the new revision of temporal_rs needs to be added, and then I think this PR should be just about good to go.

@jasonwilliams jasonwilliams mentioned this pull request Jul 31, 2024
Merged
nekevss pushed a commit to boa-dev/temporal that referenced this pull request Aug 10, 2024
@jasonwilliams
Add is empty for partialDuration (#90)
af94bbc 
Changes here are needed for boa-dev/boa#3856

- We need a way of checking if a partialDuration is empty, I don't know
if the changes here would work, open to ideas.
- We need to be able to convert from Finite64 back to f64 so I've added
a From impl (for more info see the errors
[here](https://github.com/boa-dev/boa/actions/runs/10188786383/job/28185603728?pr=3856):
@jasonwilliams
Revert "lazy builtins"
2f4afe1 
This reverts commit a4e602d.
nekevss
nekevss requested changes Aug 11, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I had a few suggestions / noticed some places where some expects can be removed to potentially get rid of the panics that popped up on the conformance testing.

core/engine/src/builtins/temporal/plain_year_month/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/plain_year_month/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/plain_month_day/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/plain_month_day/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/plain_year_month/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/plain_year_month/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/plain_month_day/mod.rs Outdated Show resolved Hide resolved
core/engine/src/builtins/temporal/plain_year_month/mod.rs Outdated Show resolved Hide resolved
nekevss
nekevss approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work! 😄

jedel1043
jedel1043 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jedel1043 jedel1043 added this to the next-release milestone Aug 13, 2024
@jedel1043 jedel1043 added the builtins PRs and Issues related to builtins/intrinsics label Aug 13, 2024
@jedel1043 jedel1043 added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 5ee0dc1 Aug 13, 2024
13 checks passed
@jedel1043 jedel1043 deleted the temporal_methods branch August 13, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
next-release
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonwilliams @nekevss @jedel1043