Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Trace, Finalize and JsData for Convert<> #3970

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Aug 26, 2024

These should have been there from the start.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.86%. Comparing base (6ddc2b4) to head (6ef1bea).
Report is 251 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3970      +/-   ##
==========================================
+ Coverage   47.24%   51.86%   +4.61%     
==========================================
  Files         476      468       -8     
  Lines       46892    45293    -1599     
==========================================
+ Hits        22154    23490    +1336     
+ Misses      24738    21803    -2935     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team August 29, 2024 05:39
@nekevss nekevss requested a review from a team August 29, 2024 05:40
@nekevss nekevss added the Internal Category for changelog label Aug 29, 2024
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat merged commit 4778780 into boa-dev:main Sep 9, 2024
14 checks passed
@HalidOdat HalidOdat added this to the next-release milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants