Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix link to examples #4007

Merged
merged 1 commit into from
Sep 24, 2024
Merged

docs: Fix link to examples #4007

merged 1 commit into from
Sep 24, 2024

Conversation

it-a-me
Copy link
Contributor

@it-a-me it-a-me commented Sep 24, 2024

This Pull Request fixes/closes #4006

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.80%. Comparing base (6ddc2b4) to head (fcd7d73).
Report is 266 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4007      +/-   ##
==========================================
+ Coverage   47.24%   52.80%   +5.55%     
==========================================
  Files         476      480       +4     
  Lines       46892    46673     -219     
==========================================
+ Hits        22154    24644    +2490     
+ Misses      24738    22029    -2709     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment this looks good to me! :)

core/engine/src/lib.rs Outdated Show resolved Hide resolved
@it-a-me
Copy link
Contributor Author

it-a-me commented Sep 24, 2024

It should be fixed now. I was just looking at the directory name rather than the crate name, mb

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jedel1043 jedel1043 added bug Something isn't working documentation update documentation labels Sep 24, 2024
@jedel1043 jedel1043 added this to the next-release milestone Sep 24, 2024
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Sep 24, 2024
Merged via the queue into boa-dev:main with commit bea8369 Sep 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to examples is broken in boa_engine
3 participants