Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegerOrInfinity eq bug fix #4010

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

Nikita-str
Copy link
Contributor

This Pull Request fixes #4009

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for the contribution! @Nikita-str

@HalidOdat HalidOdat requested a review from a team September 28, 2024 12:30
@HalidOdat HalidOdat added the bug Something isn't working label Sep 28, 2024
@HalidOdat HalidOdat added this to the next-release milestone Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.80%. Comparing base (6ddc2b4) to head (f9a9656).
Report is 268 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4010      +/-   ##
==========================================
+ Coverage   47.24%   52.80%   +5.56%     
==========================================
  Files         476      480       +4     
  Lines       46892    46671     -221     
==========================================
+ Hits        22154    24645    +2491     
+ Misses      24738    22026    -2712     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 added this pull request to the merge queue Sep 28, 2024
Merged via the queue into boa-dev:main with commit 628e31c Sep 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless loop caused by eq between IntegerOrInfinity::Integer and i64
3 participants