[chore](build) Fix compilation errors reported by GCC-13 (apache#25439)

1. Fix lots of compilation errors reported by GCC-13. 2. Fix the workflow BE UT (macOS).
bobhan1 · Oct 15, 2023 · 08f305d · 08f305d
1 parent 7ea456e
commit 08f305d
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 7 deletions.
diff --git a/.github/workflows/be-ut-mac.yml b/.github/workflows/be-ut-mac.yml
@@ -29,7 +29,7 @@ concurrency:
 jobs:
   run-ut:
     name: BE UT (macOS)
-    runs-on: macos-12
+    runs-on: macos-13
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -81,7 +81,7 @@ jobs:
             'node'
             'llvm@16'
           )
-          brew install "${cellars[@]}"
+          brew install "${cellars[@]}" || true
 
           pushd thirdparty
           branch="${{ github.base_ref }}"

diff --git a/be/CMakeLists.txt b/be/CMakeLists.txt
@@ -260,7 +260,8 @@ if (COMPILER_GCC)
     add_compile_options(-fdiagnostics-color=always
                         -Wno-nonnull
                         -Wno-stringop-overread
-                        -Wno-stringop-overflow)
+                        -Wno-stringop-overflow
+                        -Wno-array-bounds)
 endif ()
 
 if (COMPILER_CLANG)

diff --git a/be/src/olap/memtable.cpp b/be/src/olap/memtable.cpp
@@ -351,7 +351,7 @@ void MemTable::_aggregate() {
     auto& block_data = in_block.get_columns_with_type_and_name();
     std::vector<RowInBlock*> temp_row_in_blocks;
     temp_row_in_blocks.reserve(_last_sorted_pos);
-    RowInBlock* prev_row;
+    RowInBlock* prev_row = nullptr;
     int row_pos = -1;
     //only init agg if needed
     for (int i = 0; i < _row_in_blocks.size(); i++) {

diff --git a/be/src/util/bitmap_value.h b/be/src/util/bitmap_value.h
@@ -1335,6 +1335,7 @@ class BitmapValue {
                 return is_v1 ? BitmapTypeCode::type::BITMAP64 : BitmapTypeCode::type::BITMAP64_V2;
             }
         }
+        __builtin_unreachable();
     }
 
     template <typename T>

diff --git a/be/src/util/perf_counters.cpp b/be/src/util/perf_counters.cpp
@@ -262,7 +262,7 @@ bool PerfCounters::init_proc_self_io_counter(Counter counter) {
 }
 
 bool PerfCounters::init_proc_self_status_counter(Counter counter) {
-    CounterData data;
+    CounterData data {};
     data.counter = counter;
     data.source = PerfCounters::PROC_SELF_STATUS;
     data.type = TUnit::BYTES;

diff --git a/be/src/vec/aggregate_functions/aggregate_function_state_merge.h b/be/src/vec/aggregate_functions/aggregate_function_state_merge.h
@@ -24,6 +24,8 @@ const static std::string AGG_MERGE_SUFFIX = "_merge";
 
 class AggregateStateMerge : public AggregateStateUnion {
 public:
+    using AggregateStateUnion::create;
+
     AggregateStateMerge(AggregateFunctionPtr function, const DataTypes& argument_types,
                         const DataTypePtr& return_type)
             : AggregateStateUnion(function, argument_types, return_type) {}

diff --git a/be/src/vec/functions/uuid_numeric.cpp b/be/src/vec/functions/uuid_numeric.cpp
@@ -138,7 +138,7 @@ class UuidNumeric : public IFunction {
     }
 
     UInt64 randomSeed() const {
-        struct timespec times;
+        struct timespec times {};
 
         /// Not cryptographically secure as time, pid and stack address can be predictable.
 

diff --git a/be/src/vec/runtime/shared_hash_table_controller.h b/be/src/vec/runtime/shared_hash_table_controller.h
@@ -26,6 +26,7 @@
 #include <vector>
 
 #include "common/status.h"
+#include "vec/core/block.h"
 
 namespace doris {
 
@@ -42,7 +43,6 @@ class SharedHashTableDependency;
 namespace vectorized {
 
 class Arena;
-class Block;
 
 struct SharedRuntimeFilterContext {
     std::shared_ptr<MinMaxFuncBase> minmax_func;
-Original file line number
+Diff line change
@@ Expand Up / @@ -1335,6 +1335,7 @@ class BitmapValue { @@
                     return is_v1 ? BitmapTypeCode::type::BITMAP64 : BitmapTypeCode::type::BITMAP64_V2;
                 }
             }
+            __builtin_unreachable();
         }
         template <typename T>
@@ Expand Down @@