update

bobhan1 · Oct 13, 2023 · 418c70f · 418c70f
1 parent 1a25bb6
commit 418c70f
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 2 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java
@@ -507,6 +507,11 @@ private void analyzeSubquery(Analyzer analyzer, boolean skipCheck) throws UserEx
         Set<String> mentionedColumns = Sets.newTreeSet(String.CASE_INSENSITIVE_ORDER);
         List<String> realTargetColumnNames;
         if (targetColumnNames == null) {
+            if (!isFromDeleteOrUpdateStmt
+                    && analyzer.getContext().getSessionVariable().isEnableUniqueKeyPartialUpdate()) {
+                throw new AnalysisException("using native insert statement to do "
+                        + "partial update should specify the insert columns.");
+            }
             // the mentioned columns are columns which are visible to user, so here we use
             // getBaseSchema(), not getFullSchema()
             for (Column col : targetTable.getBaseSchema(false)) {

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java
@@ -81,6 +81,12 @@ public List<Rule> buildRules() {
                     boolean isNeedSequenceCol = child.getOutput().stream()
                             .anyMatch(slot -> slot.getName().equals(Column.SEQUENCE_COL));
 
+                    if (sink.getColNames().isEmpty() && sink.isFromNativeInsertStmt()
+                            && sink.isPartialUpdate()) {
+                        throw new AnalysisException("using native insert statement to do "
+                                + "partial update should specify the insert columns.");
+                    }
+
                     LogicalOlapTableSink<?> boundSink = new LogicalOlapTableSink<>(
                             database,
                             table,

diff --git a/regression-test/suites/nereids_p0/insert_into_table/partial_update.groovy b/regression-test/suites/nereids_p0/insert_into_table/partial_update.groovy
@@ -43,6 +43,10 @@ suite("nereids_partial_update_native_insert_stmt", "p0") {
     // existing rows should be updated and new rows should be inserted with unmentioned columns filled with default or null value
     sql """insert into ${tableName}(id,score) values(2,400),(1,200),(4,400)"""
     qt_1 """ select * from ${tableName} order by id; """
+    test {
+        sql """insert into ${tableName} values(2,400),(1,200),(4,400)"""
+        exception "using native insert statement to do partial update should specify the insert columns."
+    }
     sql "set enable_unique_key_partial_update=false;"
     sql "sync;"
     sql """ DROP TABLE IF EXISTS ${tableName} """

diff --git a/regression-test/suites/nereids_p0/insert_into_table/partial_update_complex.groovy b/regression-test/suites/nereids_p0/insert_into_table/partial_update_complex.groovy
@@ -77,7 +77,12 @@ suite("nereids_partial_update_native_insert_stmt_complex", "p0") {
            from ${tbName2} inner join ${tbName3} on ${tbName2}.id = ${tbName3}.id; """
 
     qt_complex_update """select * from ${tbName1} order by id;"""
-
+    test {
+        sql """insert into ${tbName1}
+           select ${tbName2}.id, ${tbName2}.c1, ${tbName2}.c3 * 100
+           from ${tbName2} inner join ${tbName3} on ${tbName2}.id = ${tbName3}.id; """
+        exception "using native insert statement to do partial update should specify the insert columns."
+    }
     sql "truncate table ${tbName1};"
     sql "truncate table ${tbName2};"
     sql "truncate table ${tbName3};"

diff --git a/...st/suites/unique_with_mow_p0/partial_update/test_partial_update_native_insert_stmt.groovy b/...st/suites/unique_with_mow_p0/partial_update/test_partial_update_native_insert_stmt.groovy
@@ -44,6 +44,10 @@ suite("test_partial_update_native_insert_stmt", "p0") {
     // existing rows should be updated and new rows should be inserted with unmentioned columns filled with default or null value
     sql """insert into ${tableName}(id,score) values(2,400),(1,200),(4,400)"""
     qt_1 """ select * from ${tableName} order by id; """
+    test {
+        sql """insert into ${tableName} values(2,400),(1,200),(4,400)"""
+        exception "using native insert statement to do partial update should specify the insert columns."
+    }
     sql "set enable_unique_key_partial_update=false;"
     sql "sync;"
     sql """ DROP TABLE IF EXISTS ${tableName} """

diff --git a/...s/unique_with_mow_p0/partial_update/test_partial_update_native_insert_stmt_complex.groovy b/...s/unique_with_mow_p0/partial_update/test_partial_update_native_insert_stmt_complex.groovy
@@ -77,7 +77,12 @@ suite("test_partial_update_native_insert_stmt_complex", "p0") {
            from ${tbName2} inner join ${tbName3} on ${tbName2}.id = ${tbName3}.id; """
 
     qt_complex_update """select * from ${tbName1} order by id;"""
-
+    test {
+        sql """insert into ${tbName1}(id, c1, c3) 
+           select ${tbName2}.id, ${tbName2}.c1, ${tbName2}.c3 * 100
+           from ${tbName2} inner join ${tbName3} on ${tbName2}.id = ${tbName3}.id; """
+        exception "using native insert statement to do partial update should specify the insert columns."
+    }
     sql "truncate table ${tbName1};"
     sql "truncate table ${tbName2};"
     sql "truncate table ${tbName3};"