[fix](Nereids) count should not accept complex and json type (apache#…

…25354)
bobhan1 · Oct 16, 2023 · 4c57c31 · 4c57c31
1 parent dfc7d04
commit 4c57c31
Show file tree

Hide file tree

Showing 4 changed files with 184 additions and 178 deletions.
diff --git a/fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java b/fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java
@@ -446,6 +446,11 @@ public boolean isOnlyMetricType() {
         return isObjectStored() || isComplexType() || isJsonbType() || isVariantType();
     }
 
+    public static final String OnlyObjectTypeErrorMsg =
+            "Doris hll, bitmap column must use with specific function, and don't"
+                    + " support filter, group by or order by. please run 'help hll' or 'help bitmap'"
+                    + " in your mysql client.";
+
     public static final String OnlyMetricTypeErrorMsg =
             "Doris hll, bitmap, array, map, struct, jsonb, variant column must use with specific function, and don't"
                     + " support filter, group by or order by. please run 'help hll' or 'help bitmap' or 'help array'"

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Count.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Count.java
@@ -66,7 +66,7 @@ public Count(boolean distinct, Expression arg0, Expression... varArgs) {
 
     public boolean isCountStar() {
         return isStar
-                || children.size() == 0
+                || children.isEmpty()
                 || (children.size() == 1 && child(0) instanceof Literal);
     }
 
@@ -82,8 +82,11 @@ public void checkLegalityBeforeTypeCoercion() {
     public void checkLegalityAfterRewrite() {
         // after rewrite, count(distinct bitmap_column) should be rewritten to bitmap_union_count(bitmap_column)
         for (Expression argument : getArguments()) {
-            if (argument.getDataType().isOnlyMetricType()) {
-                throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
+            if (argument.getDataType().isObjectType()) {
+                throw new AnalysisException(Type.OnlyObjectTypeErrorMsg);
+            }
+            if (distinct && argument.getDataType().isComplexType()) {
+                throw new AnalysisException("COUNT DISTINCT could not process complex type " + this.toSql());
             }
         }
     }