Skip to content

Commit

Permalink
add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
bobhan1 committed Dec 19, 2024
1 parent 37a99f3 commit 8d228d6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 0 additions & 4 deletions be/src/cloud/pb_convert.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ void doris_rowset_meta_to_cloud(RowsetMetaCloudPB* out, const RowsetMetaPB& in)
}
out->set_txn_expiration(in.txn_expiration());
out->set_segments_overlap_pb(in.segments_overlap_pb());
out->set_compaction_level(in.compaction_level());
out->set_segments_key_bounds_truncated(in.segments_key_bounds_truncated());
out->mutable_segments_file_size()->CopyFrom(in.segments_file_size());
out->set_index_id(in.index_id());
Expand Down Expand Up @@ -129,7 +128,6 @@ void doris_rowset_meta_to_cloud(RowsetMetaCloudPB* out, RowsetMetaPB&& in) {
}
out->set_txn_expiration(in.txn_expiration());
out->set_segments_overlap_pb(in.segments_overlap_pb());
out->set_compaction_level(in.compaction_level());
out->set_segments_key_bounds_truncated(in.segments_key_bounds_truncated());
out->mutable_segments_file_size()->Swap(in.mutable_segments_file_size());
out->set_index_id(in.index_id());
Expand Down Expand Up @@ -230,7 +228,6 @@ void cloud_rowset_meta_to_doris(RowsetMetaPB* out, const RowsetMetaCloudPB& in,
}
out->set_txn_expiration(in.txn_expiration());
out->set_segments_overlap_pb(in.segments_overlap_pb());
out->set_compaction_level(in.compaction_level());
out->set_segments_key_bounds_truncated(in.segments_key_bounds_truncated());
out->mutable_segments_file_size()->CopyFrom(in.segments_file_size());
out->set_index_id(in.index_id());
Expand Down Expand Up @@ -285,7 +282,6 @@ void cloud_rowset_meta_to_doris(RowsetMetaPB* out, RowsetMetaCloudPB&& in,
}
out->set_txn_expiration(in.txn_expiration());
out->set_segments_overlap_pb(in.segments_overlap_pb());
out->set_compaction_level(in.compaction_level());
out->set_segments_key_bounds_truncated(in.segments_key_bounds_truncated());
out->mutable_segments_file_size()->Swap(in.mutable_segments_file_size());
out->set_index_id(in.index_id());
Expand Down
4 changes: 3 additions & 1 deletion gensrc/proto/olap_file.proto
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ message RowsetMetaPB {
// to indicate whether the data between the segments overlap
optional SegmentsOverlapPB segments_overlap_pb = 51 [default = OVERLAP_UNKNOWN];
optional int64 compaction_level = 52 [default = 0];
// indicate that whether the segments key bounds is truncated
optional bool segments_key_bounds_truncated = 53 [default = false];

// For cloud
Expand Down Expand Up @@ -203,7 +204,8 @@ message RowsetMetaCloudPB {
reserved 50;
// to indicate whether the data between the segments overlap
optional SegmentsOverlapPB segments_overlap_pb = 51 [default = OVERLAP_UNKNOWN];
optional int64 compaction_level = 52 [default = 0];
reserved 52;
// indicate that whether the segments key bounds is truncated
optional bool segments_key_bounds_truncated = 53 [default = false];

// cloud
Expand Down

0 comments on commit 8d228d6

Please sign in to comment.