Allow random permutations without restrictions #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <[email protected]>
Somehow, psalm does not properly infer the returned `OrderedListInterface<TValue>` generic and thus is not happy with this comparison. I guess this is a bug but I do not want to hassle with it right now. Signed-off-by: Maximilian Bösing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the initial PR, I prevented
shufflefrom returning the same value as the initial value. Since this might not be the expected outcome, I removed this behavior. Especially as that would prevent use-cases in real-world projects which want to use theshufflemethod to i.e. load balance between multiple hostnames as the configured order would never be a result after usingshufflewhich basically prevents a specific order from being used at any time.