Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NYC Yellow Taxi Analysis - Nov 2022 Data #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BhaswatiRoy
Copy link

@BhaswatiRoy BhaswatiRoy commented Mar 11, 2023

@bryevdv
Copy link
Member

bryevdv commented Mar 14, 2023

Hi @BhaswatiRoy thanks for the PR, this satisfies the micro task. I think you have a great command of the Bokeh API already, and thank you for linking to plot images for easy viewing. My main comment would be that the notebooks and plots could use more "story", e.g. the plots themselves could often benefit from axis labels and other annotations and the notebooks could benefit from some narrative text or comments explaining what is to be looked at, why it is interesting, any conclusions the plots supports, etc.

cc @pavithraes for additional comments

@BhaswatiRoy
Copy link
Author

Hello @bryevdv, thanks for pointing this out. I will try to include these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Micro task] Explore NYC taxi trips dataset
2 participants