Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failure when using println! and dbg #10

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

senkenn
Copy link
Collaborator

@senkenn senkenn commented May 10, 2024

This pull request fixes an issue where the CI pipeline fails when there are println! or dbg statements in the code. The failure occurs because these statements are not allowed in the CI environment. To fix this, the code has been modified to remove or comment out the println! and dbg statements. This ensures that the CI pipeline runs successfully without any errors.

Fixes #4

@senkenn senkenn changed the base branch from main to new_matrix May 10, 2024 14:18
@senkenn senkenn self-assigned this May 10, 2024
@senkenn senkenn marked this pull request as draft May 10, 2024 14:20
@senkenn senkenn marked this pull request as ready for review May 10, 2024 14:29
@senkenn senkenn requested a review from bokutotu May 10, 2024 14:29
@bokutotu
Copy link
Owner

bokutotu commented May 13, 2024

結局、このPRを見る感じ、CIいらないんじゃないか説が出てきた
GPUの部分がテストできなくて色々こねくり回すぐらいなら、いらんのじゃないという

万が一コントリビューターが増えたらつければいいのではというね。

@senkenn
Copy link
Collaborator Author

senkenn commented May 15, 2024

おけ、任せるわ

@bokutotu bokutotu merged commit 7ebba98 into new_matrix May 15, 2024
3 checks passed
@bokutotu bokutotu deleted the senkenn/issue4 branch May 15, 2024 20:44
bokutotu added a commit that referenced this pull request Dec 30, 2024
Fix CI failure when using `println!` and `dbg`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ciでprintln!dbgがある場合は落ちるようにする
2 participants