Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement filter list #124

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alexzhang1030
Copy link
Contributor

Quick preview:

preview

Currently stage: draft

Need some feedback and suggestions:

  • Do we need to separate the filter mode to avoid key conflicts caused by movement (hjkl) and selection (space) in normal mode?

usage:

p.select({
  options: [{ value: 'basic', label: 'Basic' }],
  message: 'Select an example to run.',
  enableFilter: true, // enable filterable
});

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2023

⚠️ No Changeset found

Latest commit: 765a0cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexzhang1030
Copy link
Contributor Author

/cc @natemoo-re @ulken need some suggestions 🙏

packages/core/package.json Outdated Show resolved Hide resolved
Co-authored-by: Vasilii A <[email protected]>
Comment on lines +48 to +54
if (filtered.length) {
this.options = filtered.map(
({ item }) => this.originalOptions.find(({ value }) => value === item)!
);
} else {
this.options = [];
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a shorter version:

Suggested change
if (filtered.length) {
this.options = filtered.map(
({ item }) => this.originalOptions.find(({ value }) => value === item)!
);
} else {
this.options = [];
}
this.options = filtered.map(
({ item }) => this.originalOptions.find(({ value }) => value === item)!
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants