-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@clack/prompts): add prompt workflow
#139
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 4365f19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Initial thoughts:@Mist3rBru Great Work 🙏🏼 , I actually kinda of like this.. This could be a great addition. I'm just not for sure on the namespace Additional thoughtsI also think, within the next couple of releases -- I want to focus on knocking out a few bugs reported, then exposing each individual Thanks, |
I agree, sounds more like an await p.workflow()
.step('name', () => p.text())
.run() |
@Mist3rBru I like that. My only questions here
|
We can release it, and open a pinned issue like v1.0.0 Roadmap, so people can give their thoughts, and we decide based on it. |
I think it is a better API, since it does not deal with inference errors, and is more extensible. |
builder
workflow
@Mist3rBru I made some improvements to examples please check this out: de9f5b6 |
@cpreston321 commit included. This helps a lot to run the examples! |
Since Typescript has shown a limitation on infer
group
results, discussed in @chrissantamaria's comment on PR#102, and Issue #131. This functionality presents an alternative for users who favor the builder pattern when dealing with multiple prompts in sequence, serving as either a workaround or an additional choice, while avoid a breaking change.This PR includes:
I am open to discussions on comment's section!
Closes #131
Closes #109