Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added p.spinnerGroup API #158

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JoshuaKGoldberg
Copy link
Collaborator

Recording of the npx tsc examples/basic/spinnerGroup.ts:

Screen.Recording.2023-08-31.at.2.25.43.PM.mov

The same npx tsc examples/basic/spinnerGroup.ts's end output:

┌  spinner groups start...
│
◇  example stopped
│
◇  Outer group
│
└  spinner group stop...

THROW_ERROR=yippee npx tsc examples/basic/spinnerGroup.ts output:

┌  spinner groups start...
│
◇  example stopped
│
│  ┌ Outer group
│  │ First sub-task
│  ■ Second sub-task > yippee
│
└  spinner group stop...

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

⚠️ No Changeset found

Latest commit: e221f9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 1, 2023 13:17
@JoshuaKGoldberg
Copy link
Collaborator Author

cc @cpreston321 / @natemoo-re, un-drafting this for review. I can set up a changesets entry if you think it looks good?

@JoshuaKGoldberg
Copy link
Collaborator Author

Closing out my old PRs. Cheers!

@JoshuaKGoldberg
Copy link
Collaborator Author

Since Clack PRs are getting merged again (whoo!), re-opening this. 🙂

@natemoo-re
Copy link
Member

@JoshuaKGoldberg hooray! Are you up for rebasing this and adding in the CI logic from #169 ?

@JoshuaKGoldberg
Copy link
Collaborator Author

Woop! Working on it now 🚀

Copy link

pkg-pr-new bot commented Jan 6, 2025

Open in Stackblitz@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@158
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@158

commit: e221f9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants