This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Update numbers to represent actual damage numers rather than halved numbers #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the numbers represented a heart. So 1 heart = 1 damage. However, Minecraft's health actually works as 1 health = 1 half heart. This change makes it so that every damage number is accurate to Miencraft's health system. So, 1 damage = 1 half heart.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this pull request, the mod would show you the damage value in terms of hearts. Meaning if you hit it for 2 damage with this mod, that means you hit for 2 hearts.
However, Minecraft keeps track of health and damage in terms of half hearts. In other words, 1 damage = 1 half heart. This means if your sword says it does 4 damage it means it does 2 hearts of damage.
This pull request changes the mod so that it displays damage the same way Minecraft keeps track of it. It also brings it in line with other mods like Toro's DamageIndicators.