-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20321 fix consistent interpolations check #2
20321 fix consistent interpolations check #2
Conversation
Finds largest glossary for a language pair and uses it
Liquid tags are delimited by {{ }} or {% %}. Closes bookingexperts/support#17444
…s check Note that interpolation checks can be skipped on specific keys using the 'ignore_inconsistent_interpolations' property in the yaml config file Ref bookingexperts/support#20321
0b427c7
to
c23f0a0
Compare
Introduced by previous commits, but never tested before Closes bookingexperts/support#20321
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@tom-brouwer-bex you will take care of merging and pushing to the main branch yourself? |
@gstokkink Yes, I'll take care of that once the updated interpolations are on production. Since it's a rebase, I'll first copy the existing 'main' branch to another branch, before force-pushing, to ensure we can revert if we see any issues. |
@gstokkink The interpolation fixes were on production, and I've now force-pushed this branch to the main branch. If we see issues, I've archived the old main branch under backup-main/20240214 so we can restore it again. Manually closing this pull-request |
Adds liquid tag consistency validation to the interpolation check, and rebased from the original repository.
Additional validations:
Note that the following commits from our own for were removed in this rebase, since they were implemented in the original repository:
Considerations for merging:
Closes bookingexperts/support#20321