Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .cpp files in the algo subfolder to the add_library command in CMakeLists.txt for Fiber #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjhegedus
Copy link

After building Fiber successfully, I attempted to use it from my project and linking failed with the cryptic error, "undefined reference to vtable" in the constructor for the round_robin class.

A little searching on google led me to this issue on Stack Overflow... https://stackoverflow.com/questions/3065154/undefined-reference-to-vtable.

After reviewing the CMakeLists.txt file and the structure of the src folder, I found that the .cpp files in the algo subfolder of src were not included in the add_library command in the CMakeLists.txt file.

I made a very small change to add them to the add_library command in the CMakeLists.txt file. I tested the change on Windows 10, cross compiling to the Magic Leap (an Android variant) and the error was resolved. This has had minimal testing but it looks pretty clear that the missing files were the issue and the fix was very simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant